Make function param name match to help clangd and IDEs - #640

Walkthrough

ProactorBase::AwaitBrief now uses brief for its callable parameter throughout the implementation. Control flow and behavior remain unchanged.

Changes

AwaitBrief parameter rename

Estimated code review effort: 1 (Trivial) | ~2 minutes

• X
• Mastodon
• Reddit
• LinkedIn

Summary: This PR aligns the AwaitBrief implementation parameter name with its declaration.
Why: The consistent brief name removes clangd/IDE false positives while preserving the existing forwarding, invocation, and result-handling behavior.

_{🤖 Was this summary useful? React with 👍 or 👎}

• Rename AwaitBrief parameter to match declaration/definition for clangd-based IDEs
• Reduce false-positive diagnostics around AwaitBrief usage without changing behavior

graph TD
  C["Caller thread"] --> A["ProactorBase::AwaitBrief"] --> D["DispatchBrief"] --> L["Lambda runs brief"] --> R["ResultMover + Done"]

Loading

This is the most direct, lowest-risk fix: aligning the parameter identifier between declaration/definition avoids clangd/IDE confusion without affecting ABI or runtime behavior. Alternatives (e.g., suppressing diagnostics or changing tooling settings) are less reliable and harder to enforce across contributors.

Refactor (1) +5 / -5

proactor_base.hRename AwaitBrief parameter from f to brief for clangd friendliness +5/-5

Rename AwaitBrief parameter from f to brief for clangd friendliness

• Renames the AwaitBrief template parameter and all local uses from 'f' to 'brief', including decltype deduction and the lambda capture. No behavioral or control-flow changes; this is intended to suppress clangd-based false positives in IDEs.

util/fibers/proactor_base.h

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗