Tags: tdgao/code
Tags
Hide locked filter controls if they've been overridden (modrinth#4682)
Fix normalized skins uploading to Mojang (modrinth#4646) * Fix normalized skins uploading to Mojang * Run app-frontend > fix
Fix OLED colors (modrinth#4638) * Make OLED theme proper dark again, shifting surface vars up one. * Revert tertiary text color
Gotenberg/PDF gen implementation (modrinth#4574) * Gotenberg/PDF gen implementation * Security, PDF type enum, propagate client * chore: query cache, clippy, fmt * clippy fixes + tombi * Update env example, add GOTENBERG_CALLBACK_URL * Remove test code * Fix .env, docker-compose * Update purpose of payment * Add internal networking guards to gotenberg webhooks * Fix error * Fix lint
Reapply "refactor(app): reduce tech debt by eliminating `wry` fork" (m… …odrinth#4555) * Reapply "refactor(app): reduce tech debt by eliminating `wry` fork (modrinth#4500)" This reverts commit 2535156. * test: temporarily replace ad link by something with sound * Revert "test: temporarily replace ad link by something with sound" This reverts commit 74bb7ee. * Reapply "test: temporarily replace ad link by something with sound" This reverts commit f1b0e9f. * test: also disable ads init muting script for good measure * Revert "test: also disable ads init muting script for good measure" This reverts commit 4ac7a81. * Revert "Reapply "test: temporarily replace ad link by something with sound"" This reverts commit c5f1b9f.
fix(app): make MC <1.12.2 downloadable again (modrinth#4494) PR modrinth#4270 modified the internal `fetch` function used by the application to download version artifacts in a way that 4xx HTTP errors also caused an abnormal return, instead of just 5xx errors. That was a good change, but it had the unintended side effect of exposing our faulty logic elsewhere of trying to download non-native JAR library artifacts when only native artifacts are appropriate, at least according to the PrismLauncher source code I've read. Such a download always returned a 404 error, but because such error was considered successful, a dummy library file was still created and things worked seemingly fine. These changes bring the Modrinth App behavior in this regard more in line with PrismLauncher's, avoiding downloading non-native artifacts for dependencies that have native artifacts available. (Reference: https://github.com/PrismLauncher/PrismLauncher/blob/8b5e91920dda7324ad3db98f56b209bba0f4e57d/launcher/minecraft/Library.cpp#L163) I've tested these changes to work successfully with a variety of old vanilla and modded Minecraft versions. Fixes modrinth#4464.
tweak(path-util): addendum to modrinth#4482 (modrinth#4486) * tweak(path-util): addendum to modrinth#4482 These changes improve on those introduced in modrinth#4482 in two ways: - The serialization logic for `SafeRelativeUtf8UnixPathBuf` now more closely mirrors the deserialization checks, reducing the chance that a generated path will fail to deserialize. While unlikely in practice, catching such theoretical cases earlier improves the experience for users and developers. - After deeper testing on a clean Windows 10 VM, I found that reserved device names can have both an extension and an alternate data stream appended, not just one or the other. These changes handle that case more gracefully. * chore: fix typos, add tests * fix(path-util): extend `SafeRelativeUtf8UnixPathBuf` contract to allow `.` components While quite useless, they were accepted by previous app versions, the `.mrpack` specification does not forbid them, and they do not pose security issues, so accept them for backwards compatibility.
PreviousNext