Skip to content

remove roots - #108

Closed
tombl wants to merge 0 commit into
mainfrom
push-xspnovkuzqok
Closed

remove roots#108
tombl wants to merge 0 commit into
mainfrom
push-xspnovkuzqok

Conversation

@tombl

@tombl tombl commented Jul 14, 2025

Copy link
Copy Markdown
Owner

subsume all functionality into child part, and replace createRoot with a shim around child part creation.

@tombl
tombl force-pushed the push-xspnovkuzqok branch from 8d2092b to 6f29a04 Compare July 14, 2025 14:55
@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

Size Change: +32 B (+1.05%)

Total Size: 3.09 kB

Filename Size Change
./dist/client.min.js 1.71 kB +32 B (+1.91%)
ℹ️ View Unchanged
Filename Size
./dist/index.min.js 58 B
./dist/server.min.js 796 B
./dist/shared.min.js 525 B

compressed-size-action

@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

🐰 Bencher Report

Branchpush-xspnovkuzqok
Testbedgha

🚨 18 Alerts

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
anim/small/advanceduration
milliseconds (ms)
📈 plot
🚷 threshold
🚨 alert (🔔)
3.42 ms
(-29.80%)Baseline: 4.87 ms
3.46 ms
(101.33%)

tree/large/removeAllheap
kilobytes (KB)
📈 plot
🚷 threshold
🚨 alert (🔔)
606.39 KB
(-40.29%)Baseline: 1,015.50 KB
797.92 KB
(131.59%)

tree/large/renderduration
milliseconds (ms)
📈 plot
🚷 threshold
🚨 alert (🔔)
1.95 ms
(-39.16%)Baseline: 3.21 ms
2.49 ms
(127.29%)

tree/small/insertFirstduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
410.78 µs
(-33.99%)Baseline: 622.31 µs
468.87 µs
(114.14%)

tree/small/insertLastduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
377.33 µs
(-35.12%)Baseline: 581.60 µs
428.04 µs
(113.44%)

tree/small/moveFromEndToStartduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
355.47 µs
(-35.66%)Baseline: 552.46 µs
402.66 µs
(113.28%)

tree/small/moveFromStartToEndduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
362.87 µs
(-37.07%)Baseline: 576.62 µs
422.59 µs
(116.46%)

tree/small/no_changeduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
298.02 µs
(-31.30%)Baseline: 433.80 µs
356.67 µs
(119.68%)

tree/small/removeAllduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
320.03 µs
(-41.12%)Baseline: 543.56 µs
331.19 µs
(103.49%)

tree/small/removeAllheap
kilobytes (KB)
📈 plot
🚷 threshold
🚨 alert (🔔)
125.04 KB
(-18.28%)Baseline: 153.02 KB
125.56 KB
(100.41%)

tree/small/removeFirstduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
396.78 µs
(-33.94%)Baseline: 600.67 µs
445.75 µs
(112.34%)

tree/small/removeLastduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
300.33 µs
(-37.68%)Baseline: 481.89 µs
379.11 µs
(126.23%)

tree/small/renderduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
364.33 µs
(-33.89%)Baseline: 551.09 µs
458.08 µs
(125.73%)

tree/small/renderheap
kilobytes (KB)
📈 plot
🚷 threshold
🚨 alert (🔔)
135.65 KB
(-15.50%)Baseline: 160.53 KB
140.31 KB
(103.43%)

tree/small/reverseduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
389.89 µs
(-34.34%)Baseline: 593.82 µs
436.18 µs
(111.87%)

tree/worst_case/kividuration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
664.90 µs
(-38.45%)Baseline: 1,080.28 µs
698.21 µs
(105.01%)

tree/worst_case/snabbdomduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
593.13 µs
(-44.32%)Baseline: 1,065.17 µs
761.26 µs
(128.35%)

tree/worst_case/virtual_domduration
microseconds (µs)
📈 plot
🚷 threshold
🚨 alert (🔔)
608.08 µs
(-41.35%)Baseline: 1,036.74 µs
757.37 µs
(124.55%)

Click to view all benchmark results
BenchmarkdurationBenchmark Result
microseconds (µs)
(Result Δ%)
Lower Boundary
microseconds (µs)
(Limit %)
heapBenchmark Result
bytes (B)
(Result Δ%)
Lower Boundary
bytes (B)
(Limit %)
anim/large/advance📈 view plot
🚷 view threshold
7,950.11 µs
(-34.62%)Baseline: 12,159.01 µs
7,241.66 µs
(91.09%)
📈 view plot
🚷 view threshold
2,685,659.43 B
(-14.85%)Baseline: 3,154,186.57 B
2,460,196.26 B
(91.60%)
anim/small/advance📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3,419.30 µs
(-29.80%)Baseline: 4,870.57 µs
3,464.88 µs
(101.33%)

📈 view plot
🚷 view threshold
860,312.51 B
(-15.46%)Baseline: 1,017,581.35 B
764,502.07 B
(88.86%)
table/large/activate📈 view plot
🚷 view threshold
27,135.94 µs
(-2.35%)Baseline: 27,789.33 µs
23,845.63 µs
(87.87%)
📈 view plot
🚷 view threshold
9,532,509.09 B
(+21.07%)Baseline: 7,873,256.81 B
6,136,777.95 B
(64.38%)
table/large/filter📈 view plot
🚷 view threshold
77,946.33 µs
(+37.31%)Baseline: 56,766.42 µs
18,038.69 µs
(23.14%)
📈 view plot
🚷 view threshold
12,925,440.00 B
(+39.68%)Baseline: 9,253,542.65 B
3,786,951.72 B
(29.30%)
table/large/removeAll📈 view plot
🚷 view threshold
46,590.73 µs
(+10.87%)Baseline: 42,023.59 µs
13,307.66 µs
(28.56%)
📈 view plot
🚷 view threshold
7,529,708.31 B
(-2.45%)Baseline: 7,718,620.25 B
2,153,705.86 B
(28.60%)
table/large/render📈 view plot
🚷 view threshold
26,235.38 µs
(-3.34%)Baseline: 27,142.24 µs
20,438.18 µs
(77.90%)
📈 view plot
🚷 view threshold
8,815,957.33 B
(+0.52%)Baseline: 8,770,768.07 B
6,422,613.18 B
(72.85%)
table/large/sort📈 view plot
🚷 view threshold
77,473.87 µs
(+44.65%)Baseline: 53,560.73 µs
17,096.75 µs
(22.07%)
📈 view plot
🚷 view threshold
10,442,752.00 B
(+48.97%)Baseline: 7,009,758.34 B
2,677,970.35 B
(25.64%)
table/small/activate📈 view plot
🚷 view threshold
2,372.63 µs
(-9.19%)Baseline: 2,612.77 µs
2,169.32 µs
(91.43%)
📈 view plot
🚷 view threshold
1,183,371.64 B
(+30.98%)Baseline: 903,508.30 B
414,123.92 B
(35.00%)
table/small/filter📈 view plot
🚷 view threshold
4,562.83 µs
(+12.36%)Baseline: 4,061.05 µs
2,358.73 µs
(51.69%)
📈 view plot
🚷 view threshold
1,701,100.31 B
(+58.30%)Baseline: 1,074,594.25 B
227,539.67 B
(13.38%)
table/small/removeAll📈 view plot
🚷 view threshold
2,709.89 µs
(-16.72%)Baseline: 3,253.83 µs
1,867.12 µs
(68.90%)
📈 view plot
🚷 view threshold
675,176.68 B
(+40.79%)Baseline: 479,578.92 B
-67,748.32 B
(-10.03%)
table/small/render📈 view plot
🚷 view threshold
2,762.70 µs
(-12.93%)Baseline: 3,172.97 µs
2,369.05 µs
(85.75%)
📈 view plot
🚷 view threshold
1,134,239.48 B
(+41.65%)Baseline: 800,724.46 B
387,763.61 B
(34.19%)
table/small/sort📈 view plot
🚷 view threshold
4,666.30 µs
(+11.76%)Baseline: 4,175.29 µs
2,039.20 µs
(43.70%)
📈 view plot
🚷 view threshold
618,696.50 B
(-11.87%)Baseline: 701,999.58 B
255,301.66 B
(41.26%)
tree/large/removeAll📈 view plot
🚷 view threshold
2,775.32 µs
(-23.59%)Baseline: 3,632.19 µs
2,479.40 µs
(89.34%)
📈 view plot
🚷 view threshold
🚨 view alert (🔔)
606,386.09 B
(-40.29%)Baseline: 1,015,495.71 B
797,921.55 B
(131.59%)

tree/large/render📈 view plot
🚷 view threshold
🚨 view alert (🔔)
1,952.38 µs
(-39.16%)Baseline: 3,208.88 µs
2,485.14 µs
(127.29%)

📈 view plot
🚷 view threshold
920,396.72 B
(-13.29%)Baseline: 1,061,456.33 B
829,703.05 B
(90.15%)
tree/large/reverse📈 view plot
🚷 view threshold
3,380.73 µs
(-21.44%)Baseline: 4,303.22 µs
3,223.94 µs
(95.36%)
📈 view plot
🚷 view threshold
876,352.00 B
(-0.76%)Baseline: 883,088.12 B
577,349.12 B
(65.88%)
tree/small/insertFirst📈 view plot
🚷 view threshold
🚨 view alert (🔔)
410.78 µs
(-33.99%)Baseline: 622.31 µs
468.87 µs
(114.14%)

📈 view plot
🚷 view threshold
158,943.63 B
(-13.00%)Baseline: 182,704.30 B
139,244.56 B
(87.61%)
tree/small/insertLast📈 view plot
🚷 view threshold
🚨 view alert (🔔)
377.33 µs
(-35.12%)Baseline: 581.60 µs
428.04 µs
(113.44%)

📈 view plot
🚷 view threshold
157,931.70 B
(-8.36%)Baseline: 172,342.79 B
130,436.78 B
(82.59%)
tree/small/moveFromEndToStart📈 view plot
🚷 view threshold
🚨 view alert (🔔)
355.47 µs
(-35.66%)Baseline: 552.46 µs
402.66 µs
(113.28%)

📈 view plot
🚷 view threshold
102,610.23 B
(-9.28%)Baseline: 113,104.95 B
88,196.54 B
(85.95%)
tree/small/moveFromStartToEnd📈 view plot
🚷 view threshold
🚨 view alert (🔔)
362.87 µs
(-37.07%)Baseline: 576.62 µs
422.59 µs
(116.46%)

📈 view plot
🚷 view threshold
123,416.91 B
(-10.90%)Baseline: 138,508.83 B
107,989.10 B
(87.50%)
tree/small/no_change📈 view plot
🚷 view threshold
🚨 view alert (🔔)
298.02 µs
(-31.30%)Baseline: 433.80 µs
356.67 µs
(119.68%)

📈 view plot
🚷 view threshold
113,201.38 B
(-18.32%)Baseline: 138,596.70 B
109,907.18 B
(97.09%)
tree/small/removeAll📈 view plot
🚷 view threshold
🚨 view alert (🔔)
320.03 µs
(-41.12%)Baseline: 543.56 µs
331.19 µs
(103.49%)

📈 view plot
🚷 view threshold
🚨 view alert (🔔)
125,044.16 B
(-18.28%)Baseline: 153,016.21 B
125,555.05 B
(100.41%)

tree/small/removeFirst📈 view plot
🚷 view threshold
🚨 view alert (🔔)
396.78 µs
(-33.94%)Baseline: 600.67 µs
445.75 µs
(112.34%)

📈 view plot
🚷 view threshold
110,110.27 B
(-19.04%)Baseline: 136,004.95 B
107,804.11 B
(97.91%)
tree/small/removeLast📈 view plot
🚷 view threshold
🚨 view alert (🔔)
300.33 µs
(-37.68%)Baseline: 481.89 µs
379.11 µs
(126.23%)

📈 view plot
🚷 view threshold
113,430.08 B
(-11.15%)Baseline: 127,662.26 B
100,769.12 B
(88.84%)
tree/small/render📈 view plot
🚷 view threshold
🚨 view alert (🔔)
364.33 µs
(-33.89%)Baseline: 551.09 µs
458.08 µs
(125.73%)

📈 view plot
🚷 view threshold
🚨 view alert (🔔)
135,652.87 B
(-15.50%)Baseline: 160,533.45 B
140,307.70 B
(103.43%)

tree/small/reverse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
389.89 µs
(-34.34%)Baseline: 593.82 µs
436.18 µs
(111.87%)

📈 view plot
🚷 view threshold
110,913.25 B
(-9.11%)Baseline: 122,024.15 B
83,698.80 B
(75.46%)
tree/worst_case/kivi📈 view plot
🚷 view threshold
🚨 view alert (🔔)
664.90 µs
(-38.45%)Baseline: 1,080.28 µs
698.21 µs
(105.01%)

📈 view plot
🚷 view threshold
258,425.65 B
(+4.77%)Baseline: 246,668.65 B
172,700.81 B
(66.83%)
tree/worst_case/react📈 view plot
🚷 view threshold
739.59 µs
(-29.70%)Baseline: 1,051.98 µs
518.82 µs
(70.15%)
📈 view plot
🚷 view threshold
207,881.39 B
(-20.70%)Baseline: 262,131.21 B
174,310.05 B
(83.85%)
tree/worst_case/snabbdom📈 view plot
🚷 view threshold
🚨 view alert (🔔)
593.13 µs
(-44.32%)Baseline: 1,065.17 µs
761.26 µs
(128.35%)

📈 view plot
🚷 view threshold
189,728.53 B
(-18.86%)Baseline: 233,828.30 B
167,885.87 B
(88.49%)
tree/worst_case/virtual_dom📈 view plot
🚷 view threshold
🚨 view alert (🔔)
608.08 µs
(-41.35%)Baseline: 1,036.74 µs
757.37 µs
(124.55%)

📈 view plot
🚷 view threshold
197,415.55 B
(-15.12%)Baseline: 232,573.35 B
153,318.63 B
(77.66%)
🐰 View full continuous benchmarking report in Bencher

@tombl
tombl force-pushed the push-xspnovkuzqok branch 8 times, most recently from 6828daf to 13b6f70 Compare July 19, 2025 04:01
@tombl
tombl force-pushed the push-xspnovkuzqok branch from 13b6f70 to 32af769 Compare July 23, 2025 09:59
@tombl
tombl changed the base branch from main to push-prvtottyytuq July 23, 2025 10:00
@tombl
tombl force-pushed the push-xspnovkuzqok branch from 32af769 to f73c9c5 Compare July 23, 2025 10:48
@tombl
tombl force-pushed the push-prvtottyytuq branch from bfb57ea to 86b8af5 Compare July 23, 2025 10:48
Base automatically changed from push-prvtottyytuq to main July 23, 2025 11:40
@tombl
tombl force-pushed the push-xspnovkuzqok branch 2 times, most recently from 3511c83 to 001e525 Compare July 23, 2025 11:54
@tombl tombl closed this Jul 23, 2025
@tombl
tombl force-pushed the push-xspnovkuzqok branch from 001e525 to 8456e50 Compare July 23, 2025 12:00
@tombl
tombl deleted the push-xspnovkuzqok branch July 23, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant