replace key weakmap with Keyed type - #98
Merged
Merged
Conversation
|
Size Change: +25 B (+0.74%) Total Size: 3.4 kB
|
|
| Branch | push-lotowwowywuv |
| Testbed | gha |
Click to view all benchmark results
| Benchmark | duration | Benchmark Result microseconds (µs) (Result Δ%) | Lower Boundary microseconds (µs) (Limit %) | heap | Benchmark Result bytes (B) (Result Δ%) | Lower Boundary bytes (B) (Limit %) |
|---|---|---|---|---|---|---|
| anim/large/advance | 📈 view plot 🚷 view threshold | 9,848.45 µs(-18.32%)Baseline: 12,057.61 µs | 7,247.95 µs (73.59%) | 📈 view plot 🚷 view threshold | 3,257,064.73 B(+2.70%)Baseline: 3,171,418.64 B | 2,502,415.75 B (76.83%) |
| anim/small/advance | 📈 view plot 🚷 view threshold | 3,809.41 µs(-21.25%)Baseline: 4,837.44 µs | 3,455.64 µs (90.71%) | 📈 view plot 🚷 view threshold | 1,001,495.81 B(-2.21%)Baseline: 1,024,115.77 B | 780,872.21 B (77.97%) |
| table/large/activate | 📈 view plot 🚷 view threshold | 30,151.22 µs(+7.69%)Baseline: 27,998.21 µs | 23,922.64 µs (79.34%) | 📈 view plot 🚷 view threshold | 7,476,875.64 B(-3.93%)Baseline: 7,782,560.48 B | 6,104,191.11 B (81.64%) |
| table/large/filter | 📈 view plot 🚷 view threshold | 89,837.83 µs(+52.00%)Baseline: 59,103.74 µs | 16,883.21 µs (18.79%) | 📈 view plot 🚷 view threshold | 13,434,880.00 B(+40.61%)Baseline: 9,554,486.63 B | 3,655,192.70 B (27.21%) |
| table/large/removeAll | 📈 view plot 🚷 view threshold | 67,735.28 µs(+54.07%)Baseline: 43,964.09 µs | 12,422.11 µs (18.34%) | 📈 view plot 🚷 view threshold | 11,049,369.60 B(+38.29%)Baseline: 7,990,162.77 B | 2,222,571.09 B (20.11%) |
| table/large/render | 📈 view plot 🚷 view threshold | 33,313.00 µs(+20.62%)Baseline: 27,618.14 µs | 20,317.90 µs (60.99%) | 📈 view plot 🚷 view threshold | 10,448,249.26 B(+17.35%)Baseline: 8,903,477.10 B | 6,424,735.13 B (61.49%) |
| table/large/sort | 📈 view plot 🚷 view threshold | 89,432.76 µs(+60.38%)Baseline: 55,761.42 µs | 15,909.70 µs (17.79%) | 📈 view plot 🚷 view threshold | 12,495,530.67 B(+72.51%)Baseline: 7,243,174.52 B | 2,536,514.04 B (20.30%) |
| table/small/activate | 📈 view plot 🚷 view threshold | 2,860.27 µs(+8.93%)Baseline: 2,625.86 µs | 2,186.79 µs (76.45%) | 📈 view plot 🚷 view threshold | 1,454,722.87 B(+58.21%)Baseline: 919,488.30 B | 400,811.47 B (27.55%) |
| table/small/filter | 📈 view plot 🚷 view threshold | 5,497.22 µs(+32.15%)Baseline: 4,159.83 µs | 2,332.87 µs (42.44%) | 📈 view plot 🚷 view threshold | 2,137,829.52 B(+89.77%)Baseline: 1,126,564.97 B | 192,401.60 B (9.00%) |
| table/small/removeAll | 📈 view plot 🚷 view threshold | 4,141.50 µs(+23.77%)Baseline: 3,346.22 µs | 1,882.46 µs (45.45%) | 📈 view plot 🚷 view threshold | 768,414.63 B(+50.91%)Baseline: 509,198.99 B | -78,896.48 B (-10.27%) |
| table/small/render | 📈 view plot 🚷 view threshold | 3,116.79 µs(-1.99%)Baseline: 3,179.96 µs | 2,409.69 µs (77.31%) | 📈 view plot 🚷 view threshold | 1,212,008.25 B(+47.36%)Baseline: 822,471.73 B | 380,332.14 B (31.38%) |
| table/small/sort | 📈 view plot 🚷 view threshold | 5,543.68 µs(+29.12%)Baseline: 4,293.45 µs | 2,021.17 µs (36.46%) | 📈 view plot 🚷 view threshold | 1,062,068.71 B(+44.78%)Baseline: 733,575.72 B | 246,170.40 B (23.18%) |
| tree/large/removeAll | 📈 view plot 🚷 view threshold | 2,867.98 µs(-20.31%)Baseline: 3,598.86 µs | 2,445.92 µs (85.28%) | 📈 view plot 🚷 view threshold | 1,088,146.61 B(+5.83%)Baseline: 1,028,191.95 B | 852,464.98 B (78.34%) |
| tree/large/render | 📈 view plot 🚷 view threshold | 2,839.88 µs(-11.56%)Baseline: 3,210.91 µs | 2,589.28 µs (91.18%) | 📈 view plot 🚷 view threshold | 1,202,625.12 B(+11.85%)Baseline: 1,075,245.53 B | 840,042.63 B (69.85%) |
| tree/large/reverse | 📈 view plot 🚷 view threshold | 3,964.63 µs(-7.66%)Baseline: 4,293.74 µs | 3,259.52 µs (82.22%) | 📈 view plot 🚷 view threshold | 1,049,309.23 B(+16.76%)Baseline: 898,678.51 B | 581,324.29 B (55.40%) |
| tree/small/insertFirst | 📈 view plot 🚷 view threshold | 579.63 µs(-7.19%)Baseline: 624.52 µs | 488.32 µs (84.25%) | 📈 view plot 🚷 view threshold | 210,310.98 B(+13.62%)Baseline: 185,102.29 B | 141,287.49 B (67.18%) |
| tree/small/insertLast | 📈 view plot 🚷 view threshold | 442.36 µs(-23.68%)Baseline: 579.62 µs | 432.94 µs (97.87%) | 📈 view plot 🚷 view threshold | 164,114.32 B(-5.28%)Baseline: 173,259.22 B | 131,219.17 B (79.96%) |
| tree/small/moveFromEndToStart | 📈 view plot 🚷 view threshold | 539.28 µs(-2.96%)Baseline: 555.74 µs | 422.24 µs (78.30%) | 📈 view plot 🚷 view threshold | 127,421.89 B(+11.46%)Baseline: 114,325.13 B | 89,265.01 B (70.05%) |
| tree/small/moveFromStartToEnd | 📈 view plot 🚷 view threshold | 560.22 µs(-3.33%)Baseline: 579.53 µs | 442.73 µs (79.03%) | 📈 view plot 🚷 view threshold | 154,845.36 B(+10.60%)Baseline: 140,006.13 B | 109,412.55 B (70.66%) |
| tree/small/no_change | 📈 view plot 🚷 view threshold | 387.64 µs(-10.76%)Baseline: 434.38 µs | 368.65 µs (95.10%) | 📈 view plot 🚷 view threshold | 159,250.09 B(+13.35%)Baseline: 140,498.90 B | 111,740.96 B (70.17%) |
| tree/small/removeAll | 📈 view plot 🚷 view threshold | 425.64 µs(-21.34%)Baseline: 541.10 µs | 338.73 µs (79.58%) | 📈 view plot 🚷 view threshold | 166,731.93 B(+7.99%)Baseline: 154,395.99 B | 128,146.51 B (76.86%) |
| tree/small/removeFirst | 📈 view plot 🚷 view threshold | 554.04 µs(-8.15%)Baseline: 603.23 µs | 464.77 µs (83.89%) | 📈 view plot 🚷 view threshold | 126,914.65 B(-7.19%)Baseline: 136,741.78 B | 109,978.71 B (86.66%) |
| tree/small/removeLast | 📈 view plot 🚷 view threshold | 455.82 µs(-5.75%)Baseline: 483.62 µs | 397.84 µs (87.28%) | 📈 view plot 🚷 view threshold | 144,028.97 B(+11.17%)Baseline: 129,553.07 B | 101,261.57 B (70.31%) |
| tree/small/render | 📈 view plot 🚷 view threshold | 535.52 µs(-3.56%)Baseline: 555.27 µs | 481.19 µs (89.86%) | 📈 view plot 🚷 view threshold | 165,339.19 B(+2.71%)Baseline: 160,972.74 B | 142,528.34 B (86.20%) |
| tree/small/reverse | 📈 view plot 🚷 view threshold | 533.59 µs(-10.25%)Baseline: 594.55 µs | 451.51 µs (84.62%) | 📈 view plot 🚷 view threshold | 145,459.46 B(+17.39%)Baseline: 123,915.27 B | 84,966.04 B (58.41%) |
| tree/worst_case/kivi | 📈 view plot 🚷 view threshold | 1,140.72 µs(+4.04%)Baseline: 1,096.39 µs | 741.52 µs (65.00%) | 📈 view plot 🚷 view threshold | 302,544.48 B(+20.93%)Baseline: 250,188.85 B | 173,394.11 B (57.31%) |
| tree/worst_case/react | 📈 view plot 🚷 view threshold | 1,231.32 µs(+14.59%)Baseline: 1,074.54 µs | 552.32 µs (44.86%) | 📈 view plot 🚷 view threshold | 310,184.56 B(+16.19%)Baseline: 266,959.60 B | 178,993.50 B (57.71%) |
| tree/worst_case/snabbdom | 📈 view plot 🚷 view threshold | 951.68 µs(-10.88%)Baseline: 1,067.91 µs | 802.76 µs (84.35%) | 📈 view plot 🚷 view threshold | 272,567.99 B(+14.52%)Baseline: 238,005.73 B | 170,978.25 B (62.73%) |
| tree/worst_case/virtual_dom | 📈 view plot 🚷 view threshold | 923.01 µs(-11.08%)Baseline: 1,038.07 µs | 791.99 µs (85.81%) | 📈 view plot 🚷 view threshold | 276,873.29 B(+16.91%)Baseline: 236,824.66 B | 156,458.18 B (56.51%) |
tombl
force-pushed
the
push-lotowwowywuv
branch
2 times, most recently
from
July 12, 2025 08:42
36d72ab to
687e1f1
Compare
tombl
force-pushed
the
push-lotowwowywuv
branch
5 times, most recently
from
July 19, 2025 04:01
7b11de9 to
72879bb
Compare
tombl
force-pushed
the
push-lotowwowywuv
branch
13 times, most recently
from
July 29, 2025 11:43
a730e77 to
82a3405
Compare
tombl
force-pushed
the
push-lotowwowywuv
branch
4 times, most recently
from
August 1, 2025 13:57
28fb56e to
73becc5
Compare
because the WeakMap.prototype.set inside keyed was showing up high on traces. also moves keyed from client.ts to index.ts because its inert now.
tombl
force-pushed
the
push-lotowwowywuv
branch
2 times, most recently
from
August 2, 2025 06:58
b86f8c5 to
a20afcf
Compare
tombl
force-pushed
the
push-lotowwowywuv
branch
from
August 2, 2025 07:11
a20afcf to
9551c5b
Compare
tombl
marked this pull request as ready for review
August 2, 2025 07:12
tombl
added a commit
that referenced
this pull request
Aug 2, 2025
tombl
added a commit
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because the WeakMap.prototype.set inside keyed was showing up high on traces.
also moves keyed from client.ts to index.ts because its inert now.