Fix bug where listRefresh() would not deduplicate already existing VMs in list - #7816
Open
avighnac wants to merge 1 commit into
Open
Fix bug where listRefresh() would not deduplicate already existing VMs in list#7816avighnac wants to merge 1 commit into
listRefresh() would not deduplicate already existing VMs in list#7816avighnac wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was using UTM, I noticed that sometimes, after creating a VM, it would create two entries for that VM. On trying to delete one of the entries, the whole VM would be deleted though.
I'm not sure why the duplicate entries are being created but after looking at the code for some time, I found this function which claims to remove duplicate entries.
The thing is, however, it only seemed to remove 'newly loaded' duplicates. I added some code at the very beginning that makes it remove already existing duplicates too.
I tested this myself (Macbook Air M2, macOS Tahoe 26.5) and a Windows VM that appeared twice on the regular UTM appears only once with this patch.