Preserve case of SVG/MathML foreign-content attributes - #284
Open
QQSHI13 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minify-html lowercases every HTML attribute name, which breaks SVG (and would break MathML) foreign content: per the HTML spec, attribute names inside those subtrees are case-sensitive, so
<svg viewBox="0 0 24 24">renders differently fromviewbox. Browsers and conformant parsers (e.g. html5lib) preserve the case; minify-html does not.Repro:
Changes:
svgelement enters it, case-insensitive match) and preserve element + attribute name case inside it; HTML keeps lowercasing.minify-htmlandminify-html-onepass), since they share the test data.</linearGradient>still matches<linearGradient>.viewBoxis expected preserved; an uppercaseDon<path>is now treated as a distinct attribute (no lowercase-induced value removal).Tests:
cargo test -p minify-html -p minify-html-common -p minify-html-onepass— all green.