fix: js-yaml upgrade#6903
Open
rossmcewan wants to merge 1 commit into
Open
Conversation
macko911
approved these changes
Jul 24, 2026
rossmcewan
enabled auto-merge
July 24, 2026 09:09
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Confidence score: 3/5
- In
packages/nango-yaml/package.json, the YAML upgrade appears to change parsing of numeric-separator literals (for examplecount: 1_000) from numbers to strings, which can break or silently alternango.yamlmodel parsing at runtime; pin/adjust the parser configuration or add a compatibility transform so these values remain numeric.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/nango-yaml/package.json">
<violation number="1" location="packages/nango-yaml/package.json:16">
P2: Existing `nango.yaml` model literals that use YAML numeric separators, such as `count: 1_000`, are now loaded as strings rather than numbers after this upgrade, which can alter or break model parsing. Preserving the old interpretation through a compatibility normalization/migration (and adding a regression test) would avoid silently changing existing configurations.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }, | ||
| "dependencies": { | ||
| "js-yaml": "4.1.1", | ||
| "js-yaml": "4.3.0", |
Contributor
There was a problem hiding this comment.
P2: Existing nango.yaml model literals that use YAML numeric separators, such as count: 1_000, are now loaded as strings rather than numbers after this upgrade, which can alter or break model parsing. Preserving the old interpretation through a compatibility normalization/migration (and adding a regression test) would avoid silently changing existing configurations.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/nango-yaml/package.json, line 16:
<comment>Existing `nango.yaml` model literals that use YAML numeric separators, such as `count: 1_000`, are now loaded as strings rather than numbers after this upgrade, which can alter or break model parsing. Preserving the old interpretation through a compatibility normalization/migration (and adding a regression test) would avoid silently changing existing configurations.</comment>
<file context>
@@ -13,7 +13,7 @@
},
"dependencies": {
- "js-yaml": "4.1.1",
+ "js-yaml": "4.3.0",
"ms": "3.0.0-canary.1"
},
</file context>
rossmcewan
disabled auto-merge
July 24, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.