[16.0][IMP] shopfloor/base: Improve message management - #1165
Open
rousseldenis wants to merge 6 commits into
Open
[16.0][IMP] shopfloor/base: Improve message management#1165rousseldenis wants to merge 6 commits into
rousseldenis wants to merge 6 commits into
Conversation
Contributor
rousseldenis
force-pushed
the
16.0-imp-shopfloor-location_content_message-dro
branch
from
May 13, 2026 13:35
6071b3c to
28b57f0
Compare
If the move line is not yet created, we need to know which destination location has been computed in order to display it to user. We add also the product name
In some situations, it is convenient to store the message in a message queue at different levels of shopfloor stack and then restitute them in the response.
rousseldenis
force-pushed
the
16.0-imp-shopfloor-location_content_message-dro
branch
from
July 2, 2026 07:01
28b57f0 to
6fee966
Compare
jbaudoux
reviewed
Jul 17, 2026
| cls.data = work.component(usage="data") | ||
| cls.data_detail = work.component(usage="data_detail") | ||
| cls.msg_store = work.component(usage="message") | ||
| # cls.msg_store = work.component(usage="message") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will enhance message management in shopfloor stack.
In some situations (like the call to
_is_dest_location_valid()function, the reason of error is not known exactly depending on extension mechanisms that add logic to existing flows.So, having a stored message queue in the call stack will allow to add more context to the message for operator.
This will also improve message for location content transfer when location destination is invalid (it shows the source and destination (computed) locations. It also shows the concerned product.