[Trex] add session variables for TREX HANA sql execution#181
Open
Zhimin-arya wants to merge 2 commits into
Open
[Trex] add session variables for TREX HANA sql execution#181Zhimin-arya wants to merge 2 commits into
Zhimin-arya wants to merge 2 commits into
Conversation
Zhimin-arya
commented
Jul 23, 2026
|
|
||
|
|
||
| getConnection(db_id, schema, vocab_schema, result_schema, translationMap) { | ||
| getConnection(db_id, schema, vocab_schema, result_schema, translationMap, sessionVariables = {}) { |
Author
There was a problem hiding this comment.
allow callers such as parquet-export to provide session variables
Zhimin-arya
commented
Jul 23, 2026
| } | ||
| } | ||
|
|
||
| fn parse_session_vars(json: &str) -> Result<BTreeMap<String, String>, Box<dyn Error>> { |
Author
There was a problem hiding this comment.
The fn is copied from hana_materialize.rs using same logic to set application session variable
Zhimin-arya
commented
Jul 23, 2026
| } | ||
| let (column_names, column_types, temporal_cols) = match safe_hana_connect(url.clone()) { | ||
| Ok(connection) => { | ||
| apply_session_vars(&connection, &session_vars)?; |
Author
There was a problem hiding this comment.
Apply variables to the schema-detection connection
Zhimin-arya
commented
Jul 23, 2026
| for attempt in 0..=bind_data_ref.max_retries { | ||
| match safe_hana_connect(bind_data_ref.url.clone()) { | ||
| Ok(connection) => { | ||
| apply_session_vars(&connection, &bind_data_ref.session_vars)?; |
Author
There was a problem hiding this comment.
Apply variables to the execution connection
Zhimin-arya
commented
Jul 23, 2026
| duckdb::core::LogicalTypeHandle::from(LogicalTypeId::Varchar), | ||
| ]) | ||
| } | ||
| fn named_parameters() -> Option<Vec<(String, duckdb::core::LogicalTypeHandle)>> { |
Author
There was a problem hiding this comment.
named_parameters() tells DuckDB:
trex_hana_scan accepts an optional input called session_vars_json, and its value must be text.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
- Coverage 52.66% 52.62% -0.04%
===========================================
Files 168 168
Lines 72584 72630 +46
===========================================
- Hits 38223 38219 -4
- Misses 34361 34411 +50
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.