update idna and other dependencies#1029
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sfisher It looks like if failed unit tests. I am investigating. |
|
@sfisher Hi Scott, the github action errors were resolved. The root cause was the inconsistency of the output of
Release candidate Please review and let me know if you have questions. Thank you Jing |
sfisher
left a comment
There was a problem hiding this comment.
Hi Jing,
This worked ok for me but I had an issue with my .venv where pytest --ds=settings.tests tests/ gave errors about ui_tags.
I got it to work by using python -m pytest --ds=settings.tests tests/.
An LLM suggested adding this to the top of pyproject.toml to get the error to go away with a .venv. Most of the packages is already there but the ui_tags isn't and it says by adding it, it should enable pytest --ds=settings.tests tests/ to work correctly.
packages = [
{ include = "ezidapp" },
{ include = "settings" },
{ include = "impl" },
{ include = "ui_tags" },
]
I'm not sure that this matters much, but the updates and code itself seems ok to me.
|
@sfisher Thank you Scott for reviewing and testing! EZID uses
Jing |
@sfisher Hi Scott,
This is to update Python dependencies to resolve Dependabot alerts on Idna and cryptography. The updated code is on ezid-stg with tag
v3.3.33_rc0. Functional and UI tests look good.Please review and let me know if you have questions.
Thank you
Jing