Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Code Review
This pull request updates fnm to version 1.39.0, introducing several improvements and bug fixes. Key changes include reducing shell startup overhead for env --use-on-cd by applying the initial version during fnm env, improving shell hook robustness (especially for Windows CMD and Zsh), adding support for the x64-glibc-217 architecture, and adding --progress and --use flags to the install command. Additionally, dependencies have been adjusted, and contributor documentation has been added to AGENTS.md. The review feedback highlights two important issues: first, in .ci/install.sh, the temporary directory created by mktemp -d is not cleaned up, which can be resolved by restoring the trap command; second, in src/commands/install.rs, calling to_str().unwrap() on a path can lead to a panic if the path contains invalid UTF-8, so using to_string_lossy() is recommended for safety.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
No description provided.