Optimize repeated Map lookups with lazy index - #16
Draft
mlin wants to merge 1 commit into
Draft
Conversation
Coverage Report for CI Build 25129537403Coverage decreased (-0.09%) to 95.143%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mapkey lookups were doing a linear scan ofValue.Map.valueon every access, which is inefficient for common cases with many lookups.dictindex after the first lookup to improve performance without large refactors.Description
WDL.Value.Map:_indexand_index_failed, and initialize them in__init__.WDL.Value.Map.get(key)which lazily builds_indexon first lookup, uses_indexfor subsequent lookups, and falls back to the original linear scan when keys are unhashable in Python._index_key()helper that derives the Python dict key from aValue.Base(currently returnskey.value)._At._call_eagerto useValue.Map.get()so the optimization applies tomap[key]evaluations.Testing
ruff format WDL/Value.py WDL/StdLib.pyandruff check WDL/Value.py WDL/StdLib.py, which passed.mypy WDL/Value.py WDL/StdLib.py, which passed.pytest -q tests/test_0eval.py -k map, which passed (1 passed, 22 deselected).Codex Task