Fix OVERLEAF_INVITE_TOKEN_SECRET being ignored in server-ce settings#1499
Open
Musicminion wants to merge 1 commit into
Open
Fix OVERLEAF_INVITE_TOKEN_SECRET being ignored in server-ce settings#1499Musicminion wants to merge 1 commit into
Musicminion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With OVERLEAF_INVITE_TOKEN_SECRET set, the web service still logs on every boot:
Failed to initialise Link Sharing token encryption. Please ensure OVERLEAF_INVITE_TOKEN_SECRET is set.
and the new link-sharing invite flow throws Token encryption not configured.
(Email invites and legacy token link-sharing are unaffected, so it's easy to miss.)
This happens in overleaf ce 6.2.0.
Related issues / Pull Requests
#1498
Contributor Agreement