Follow-up to #116, which disabled three react-hooks/set-state-in-effect reports with rationale rather than fixing them. Each had a real fix that also removes state.

ColumnCard search row

Two effects existed only to open the row. Opening is a state adjustment, so it now happens during render — React re-runs the component immediately, before paint, with no cascading commit.

The query-driven open has to stay edge-triggered, and this is the part worth reviewing. The obvious version —

if (searchActive && !searchOpen) setSearchOpen(true);

— is wrong. Both the "Esc" button and the toolbar toggle close the row without clearing the query, so that test re-opens it on the very next render and the row becomes impossible to dismiss. I wrote that version first and caught it reading the close handlers. Comparing against the previous value keeps it a transition, which is what the old [searchActive] dep array was really encoding.

The mount case (a query that survived a collapse/expand or tab switch) moves to seeding searchOpen from searchActive, which also removes a one-frame flicker. The effect is left with the two jobs that genuinely belong in one: moving DOM focus and draining the one-shot / signal.

VersionHistoryDialog

The dialog stays mounted for the lifetime of the sidebar — that was the only reason it had to set a loading flag synchronously on open. Splitting the list into a child that mounts per-open and is keyed by deck makes useState's initial value the reset.

snapshots: DeckSnapshotMeta[] | null then encodes "not loaded yet" directly, so the separate loading boolean disappears — along with a one-render flash of the empty-state copy that the old loading: false default allowed on first open.

Verification

There is no test coverage for any of this (the 279 tests don't touch either file), and reasoning alone already produced one bug here, so I exercised it against a live deck in a browser:

Console: 0 React errors, 0 warnings — no "cannot update while rendering", no render loop.

eslint --max-warnings=0 clean · 279/279 tests · tsc --noEmit · next build all pass. No set-state-in-effect disables remain in the codebase.