Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

feat-extended education schema - #146

Open
saurabh-sinha21 wants to merge 5 commits into
masterfrom
featEducationExtended
Open

feat-extended education schema#146
saurabh-sinha21 wants to merge 5 commits into
masterfrom
featEducationExtended

Conversation

@saurabh-sinha21

Copy link
Copy Markdown

Implemented Extension for education schema.

@anton-iskryzhytskyi anton-iskryzhytskyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Comment thread sdk/vc-data/package-lock.json Outdated
{
"name": "@affinidi/vc-data",
"version": "1.3.7",
"version": "1.3.8",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json: updated from 1.4.0 to 1.4.1.
package-lock.json: updated from 1.3.7 to 1.3.8.

So which of these is correct?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for package.json the correct version is 1.4.1 and for package-lock.json its 1.3.8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json and package.json should have the same version (which is the package version)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants