Conversation
docs/hid.md claimed VT byte 23 (ETB / Ctrl+W) maps to `ctrl-bksp`, in both the byte→event table and the Control Byte Collisions table. The VT code keeps the Ctrl+letter identity and emits `ctrl-w` (hid.sh: 1..26 → ctrl-<letter+96>); the `ctrl-bksp` remap for byte 23 exists only in kitty "func" mode (hid.sh:389). Correct both rows to `ctrl-w` and reword the prose to explain that on terminals which send 23 for Ctrl+Backspace it also surfaces as `ctrl-w` in VT, and to use the kitty protocol to disambiguate. Verified: _tuish_resolve_event "E 23" → ctrl-w, "E 8" → ctrl-bksp. docs/tui.md listed the kitty keyboard (ESC[>9u) in the "configured at startup" table, but tuish_init never sends it and TUISH_PROTOCOL defaults to vt. Remove that row and add a note that kitty mode is opt-in via tuish_kitty_on (probed, with VT fallback) and restored by tuish_kitty_off / tuish_fini.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/hid.md claimed VT byte 23 (ETB / Ctrl+W) maps to
ctrl-bksp, in both the byte→event table and the Control Byte Collisions table. The VT code keeps the Ctrl+letter identity and emitsctrl-w(hid.sh: 1..26 → ctrl-<letter+96>); thectrl-bkspremap for byte 23 exists only in kitty "func" mode (hid.sh:389). Correct both rows toctrl-wand reword the prose to explain that on terminals which send 23 for Ctrl+Backspace it also surfaces asctrl-win VT, and to use the kitty protocol to disambiguate. Verified: _tuish_resolve_event "E 23" → ctrl-w, "E 8" → ctrl-bksp.docs/tui.md listed the kitty keyboard (ESC[>9u) in the "configured at startup" table, but tuish_init never sends it and TUISH_PROTOCOL defaults to vt. Remove that row and add a note that kitty mode is opt-in via tuish_kitty_on (probed, with VT fallback) and restored by tuish_kitty_off / tuish_fini.