Tags: andruud/wpt
Tags
[text-fragment] Fix prefix matching edge case The current algorithm first finds a |prefix|, then checks if the immediate following text is the |search_text|. If it is it'll advance |search_start| to the end of the |search_text| so it can confirm it's followed by the |suffix| text. However, this means that if the |suffix| text doesn't match, the next iteration of the algorithm will start searching for the |prefix| at the end of the |search_text|. This is a problem if the |search_text| == |prefix| because we've now skipped the |search_text| part of the range for prefix matching. E.g. With prefix=foo search_text=foo suffix=bar we'll fail to match: foo foo foo bar Because the first iteration of the loop will use the first "foo" as the prefix, and the next iteration will use the third "foo" as the prefix; we skip the second. Bug: 1054243 Change-Id: I62b8a32f89c987e5bed8ea439ae1b7d53d12436d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065979 Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743108}
Add WPT test case for rolling back data channel Bug: chromium:1032987 Change-Id: I450c68280a8ab8b0b2bbaa5fa31e0245dbfba780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066625 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#743154}
Revert "Roll CTS and fix extract_expectation_names.py" This reverts commit 51f4efc99436a226e20ece367e1027dbb8577f82. Reason for revert: rmtree fix was reverted Original change's description: > Roll CTS and fix extract_expectation_names.py > > https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 > > Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743007} TBR=kainino@chromium.org,robertma@chromium.org,enga@chromium.org,rmhasan@google.com Change-Id: I2fee3ed2df610c3fc0e385725e3ae0e86718f745 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066464 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743062}
Fix WPT reftest 'percentage-heights-004.html' to be valid even if scr… …ollbars are transparent. As currently written (before this patch), the test improperly assumes that its horizontal scrollbars will be opaque. Specifically: the testcase has a red background behind two horizontal scrollbars, whereas the reference case has a green background behind one of the scrollbars and no background behind the other. This would all be fine if the scrollbars were guaranteed to be opaque, but we don't have any such guarantee. On browsers where scrollbars are transparent, this horizontal-scrollbar-area will end up red in the testcase vs. green/white in the reference case. This patch amends the files to address this, by adjusting the testcase like so: - It changes the outer elements' background from red to tan, to avoid the "something's definitely wrong" implication of red coloring. - It adjusts the prose to account for the fact that this color might shine through a transparent scrollbar, and it's fine if it does. - It reorders the declarations for #inner and #inner2 to list width before height (just for consistency - this one's a non-functional change). ...and similarly, this patch adjusts the reference case like so: - It adds a tan background-color on both "outer" elements (instead of green & default-transparent backgrounds). - It adds a green background to #inner, and gives that element 100% height to make it fill the scrollable area with green (since #outer is no longer doing that). - It makes the same adjustment to the prose as in the testcase. Note that the testcase is mostly unchanged, so the same conditions are being tested here, before vs. after the patch. Aside from the prose change, this patch doesn't affect either file's rendering in Chrome, and it only affects the rendering in Firefox insomuch as it converts the red scrollbar-background to tan. Differential Revision: https://phabricator.services.mozilla.com/D61654 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1613103 gecko-commit: 0bc1ece93b59e10b1cfce62626b31f1af084b4ce gecko-integration-branch: autoland gecko-reviewers: cbiesinger
Add example with 'all' to WPT text-decoration-skip-ink tests. Differential Revision: https://phabricator.services.mozilla.com/D61185 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611965 gecko-commit: 3ab471678cbd8f644ad325c0b7277bbbf0f0ac02 gecko-integration-branch: autoland gecko-reviewers: emilio
Clipboard API: Consistently return on detached contexts. Consistently fail on detached contexts. Previously, a detached context could allow for a nullptr deref, and a renderer crash. Consistently return nullptr for navigator.clipboard, and ensure that a nullptr navigator.clipboard function will terminate immediately in a consistent manner. Also, add tests to ensure that regressions don't occur in the future. Bug: 1028591, 1034023 Change-Id: I67f8a76dc2901e7447049ff99e0b27ea6afeba63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057817 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742941}
Cookie names and values must exclude NULL char Differential Revision: https://phabricator.services.mozilla.com/D63205 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1595661 gecko-commit: ede13f270ff7b66da9905f826dd9d4374d7771cd gecko-integration-branch: autoland gecko-reviewers: mayhemer, annevk
Don't adjust SVG text in forced colors mode As per the following spec resolution, SVG text no longer should be adjusted in forced colors mode by default. w3c/csswg-drafts#3855 Bug: 970285 Change-Id: I11a785f64ca6f7e7840b17d6b59d4ce9b9f8b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055431 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743163}
Roll CTS and fix extract_expectation_names.py https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743007}
PreviousNext