Use a pre-commit hook for Cargo that doesn't need Cargo installed - #200
Merged
Conversation
This uses Docker under the hood. I'm not sure how well my pre-commit caching will work with it. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from a Rust pre-commit hook that requires Cargo to be installed to a Docker-based alternative that doesn't require local Rust/Cargo installation. This change aims to simplify the development environment setup by removing the dependency on having Rust toolchain installed locally.
- Replaces the
doublify/pre-commit-rusthooks with Docker-based alternatives fromandrewaylett/pre-commit-hooks - Updates the pre-commit configuration to use
cargo-fmtandcargo-clippyinstead offmtandclippy - Removes Rust toolchain setup from GitHub Actions workflow since pre-commit now handles Rust tooling via Docker
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Removes doublify/pre-commit-rust hooks, adds Docker-based cargo-fmt and cargo-clippy hooks, updates hook repository version |
.github/workflows/rust.yml |
Removes Rust toolchain setup step since Docker-based pre-commit hooks no longer require local Rust installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses Docker under the hood. I'm not sure how well my pre-commit caching will work with it.