Skip to content

Update setuptools_scm#539

Open
mihaic wants to merge 6 commits into
masterfrom
mihaic-patch-1
Open

Update setuptools_scm#539
mihaic wants to merge 6 commits into
masterfrom
mihaic-patch-1

Conversation

@mihaic

@mihaic mihaic commented Dec 11, 2023

Copy link
Copy Markdown
Member

No description provided.

@mihaic
mihaic requested a review from davidt0x December 11, 2023 19:14

@JiwaniZakir JiwaniZakir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration to [tool.setuptools_scm] with version_file = "brainiak/_version.py" is the correct approach for setuptools_scm>=8, which replaced the older write_to key. One thing worth verifying: if setup.cfg or setup.py still contains a [tool:setuptools_scm] section or a use_scm_version call with a conflicting write_to setting, the two configurations could conflict or produce duplicate/stale version files. The generated brainiak/_version.py should also be confirmed present in .gitignore — auto-generated version files should not be committed, and omitting that can cause confusing diffs. Additionally, bumping setuptools>=62 is a meaningful constraint increase; it would be worth a note in the changelog or commit message explaining that this is driven by the setuptools_scm>=8 dependency requirement, so downstream packagers aren't surprised by the tighter floor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants