Close the DAVE session when the conn is discarded#568
Merged
Conversation
topi314
approved these changes
Jul 16, 2026
This was referenced Jul 19, 2026
MrWong99
added a commit
to MrWong99/Glyphoxa
that referenced
this pull request
Jul 19, 2026
) Pseudo-version at the #568 merge commit: dave.Close() in connImpl.Close — every reconnect cycle leaked a DAVE session under v0.19.6. godave v0.2.0→v0.3.0 (indirect); dave-go v0.5.1 satisfies the new Session interface (dave-tagged build+tests green). Pin comment records next deliberate-bump condition. Closes #484. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566.
Calls
dave.Close()inconnImpl.Closeright after the gateway and udp teardown, so session implementations can stop their background work when the conn goes away for good.I only put it in
Close, not in the voice state update handler: withtryOpenGatewaythe conn can come back after a re-join, and the dave session has to survive that.Closeis the only point where the conn is really done.