Skip to content

chore: add workspace-dev target and make AUTH_BASE_URL optional#13

Merged
bjoaquinc merged 1 commit into
develfrom
chore/workspace-dev-target
Jul 10, 2026
Merged

chore: add workspace-dev target and make AUTH_BASE_URL optional#13
bjoaquinc merged 1 commit into
develfrom
chore/workspace-dev-target

Conversation

@bjoaquinc

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #12. Adds a workspace-dev target for the dev stack and makes AUTH_BASE_URL optional so a workspace can be scaffolded against a stack where auth shares the api host. Manual-test tooling only — no runtime changes.

  • make workspace-dev: wrapper pointing at the dev stack (api.dlthub.dev); auth shares the api host, so no separate AUTH_BASE_URL.
  • make workspace-env: now only requires API_BASE_URL; AUTH_BASE_URL is pinned only when set.

Changes

  • Makefile: add workspace-dev target and .PHONY entry; workspace-env no longer errors when AUTH_BASE_URL is unset and passes it through only when present.
  • scripts/pin_workspace_urls.py: auth_base_url argument is now optional (accepts 3 or 4 args); only upserts auth_base_url when provided.

Testing

  • make -n workspace-dev: expands to workspace-env API_BASE_URL=https://api.dlthub.dev and invokes the script without auth_base_url as expected.
  • Ran the script with and without the auth arg — api_base_url always pinned, auth_base_url pinned only when passed; existing keys preserved, re-run updates in place with no duplicates. ✅

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bjoaquinc
bjoaquinc merged commit 62be26f into devel Jul 10, 2026
4 checks passed
@bjoaquinc
bjoaquinc deleted the chore/workspace-dev-target branch July 10, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant