chore: add workspace-dev target and make AUTH_BASE_URL optional#13
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12. Adds a
workspace-devtarget for the dev stack and makesAUTH_BASE_URLoptional so a workspace can be scaffolded against a stack where auth shares the api host. Manual-test tooling only — no runtime changes.make workspace-dev: wrapper pointing at the dev stack (api.dlthub.dev); auth shares the api host, so no separateAUTH_BASE_URL.make workspace-env: now only requiresAPI_BASE_URL;AUTH_BASE_URLis pinned only when set.Changes
Makefile: addworkspace-devtarget and.PHONYentry;workspace-envno longer errors whenAUTH_BASE_URLis unset and passes it through only when present.scripts/pin_workspace_urls.py:auth_base_urlargument is now optional (accepts 3 or 4 args); only upsertsauth_base_urlwhen provided.Testing
make -n workspace-dev: expands toworkspace-env API_BASE_URL=https://api.dlthub.devand invokes the script withoutauth_base_urlas expected.api_base_urlalways pinned,auth_base_urlpinned only when passed; existing keys preserved, re-run updates in place with no duplicates. ✅🤖 Generated with Claude Code