Add a test for throning a feast. - #8
Open
amalloy wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks! Let me fix this issue and then I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a (failing) test for the behavior when playing Throne Room on Feast. The Feast should get trashed after gaining two Duchies, but instead it is discarded. I checked with Debug.Trace, and the player's Throne Room and Feast go into his discard pile instead of the trash; it would be nice to show that somehow in the test output, but this is my first time working with tests in haskell and I don't know how.
The fix for this is that (a) cards must go into the play area when played, and only get discarded at the end of a turn, during the cleanup phase, and (b) the Feast must get trashed at some point.