Flip prompt popover when it overflows the editor content rect (minimal proper fix) - #6
Open
shved270189 wants to merge 1 commit into
Open
Flip prompt popover when it overflows the editor content rect (minimal proper fix)#6shved270189 wants to merge 1 commit into
shved270189 wants to merge 1 commit into
Conversation
shved270189
force-pushed
the
fix-prompt-popover-overflow-minimal
branch
3 times, most recently
from
June 24, 2026 12:15
41d796a to
d3aef8f
Compare
shved270189
force-pushed
the
fix-prompt-popover-overflow-minimal
branch
from
June 24, 2026 12:52
d3aef8f to
2c68c51
Compare
shved270189
marked this pull request as ready for review
June 24, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The prompt/mention popover only flips above the cursor when it would overflow the window (
popoverRect.bottom > window.innerHeight). When a<lexxy-editor>lives inside a container that clips overflow — e.g. a fixed-height scroll area or modal composer — the menu opens downward and is cut off by that container even though the window still has room below it.Fix
Flip the menu above the cursor when the popover would overflow the editor's nearest clipping ancestor (an ancestor whose
overflow-yis notvisible), capped by the window — instead of checking the window alone:When the editor has no clipping ancestor the bound is
window.innerHeight, so an ordinary editor keeps the menu below the cursor exactly as before — the flip only kicks in when something would actually clip it.Tests
New
test/browser/tests/prompts/overflow_container.test.js+ fixture, covering both directions:Full prompts suite passes on chromium (the pre-existing macOS
cursor_moves_awayEnd-key failure is unaffected).