fix: preserve the pending WireGuard registration chain#424
Open
Serph91P wants to merge 1 commit into
Open
Conversation
Backwards-compatible registrations do not receive a wg/connect response. Do not let them replace the chain ID of a normal registration that may already be in flight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Newt sends a normal WireGuard registration and a backwards-compatible registration during startup. The normal registration stores a chain ID and waits for
newt/wg/connect. The compatibility message also replaced that stored ID, even though Pangolin intentionally does not answer compatibility registrations withnewt/wg/connect.When the compatibility message ran while the normal response was in flight, Newt rejected the valid response as stale and never initialized its WireGuard tunnel. The websocket stayed connected, which made the site look online while private client connectivity timed out.
This change keeps backwards-compatible registrations from touching
pendingRegisterChainIdin both places where they are sent. Normal registrations still set and validate their chain IDs as before.Fixes #423
How to test?
go test ./....LOG_LEVEL=DEBUG.newt/wg/connectresponse is accepted instead of being discarded with different received and expected chain IDs.Tunnel connection to server established successfullyand client connectivity becomes available.I also tested this as a patched Newt 1.15.0 binary against Pangolin 1.21.0. Before the patch, the valid registration response was consistently discarded and WireGuard remained uninitialized. After the patch, Newt established the tunnel, Gerbil recorded a current handshake, and the private resource was reachable.