refactor(secret-leak): delete duplicate betterleaks/default.toml; dependabot drop-in header#103
Merged
Merged
Conversation
…endabot drop-in header - Delete betterleaks/default.toml. Its ruleset is now the single canonical .betterleaks.toml base; the weekly org audit's one divergence (disabling generic-api-key) is expressed as a generated [extend] overlay on the audit side. Update the stale "Org default.toml" note in reusable-secret-leak-check.yml to name the canonical base. betterleaks/ now holds only the pre-commit example. - pinact/dependabot.yml: rewrite the header as a drop-in config. The Backstage scaffolder now fetches this file into repos, so it should not read as copy-me instructions; adoption and merge guidance stay in docs/github-actions-pinning.md. GATED: merge only after the weekly audit (geolonia-operations) stops fetching betterleaks/default.toml. Deleting it before that lands would 404 the audit's config fetch.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughThe reusable secret-leak workflow now references a new pinned Betterleaks image digest, the obsolete Betterleaks default configuration is removed, and Dependabot configuration comments are updated without changing operational settings. ChangesBetterleaks scanning
Dependabot guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
🛡️ Security suite
Note All security checks passed. Updated for |
dkastl
marked this pull request as ready for review
July 24, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the Security Suite single-source-of-truth consolidation (tracking issue: geolonia-operations#236).
Changes
Delete
betterleaks/default.toml. It duplicated the per-PR allowlists and differed only by disablinggeneric-api-key. After the weekly audit switches to the canonical.betterleaks.tomlbase + a generated one-line[extend]overlay, this file is unused. Deleting it leaves one betterleaks config in the repo, resolving the "two similar TOMLs" confusion. The staleOrg default.tomlnote inreusable-secret-leak-check.ymlnow names the canonical base.betterleaks/retains only the pre-commit example.pinact/dependabot.yml: drop-in header. The Backstage scaffolder now fetches this file directly into repos (geolonia-backstage#274, merged), so its header no longer reads as "copy this file to ..." instructions. Adoption/merge guidance stays indocs/github-actions-pinning.md.GATED - merge order
The deletion depends on the weekly audit no longer fetching
betterleaks/default.toml:Merging this before #237 would 404 the audit's config fetch on its next run. Holding as draft until #237 lands.
Not included: drift-check (deferred, see below)
Summary by CodeRabbit
Security
Documentation