Skip to content

Add GitHub Actions tests#31

Open
cclauss wants to merge 1 commit into
hishamhm:masterfrom
cclauss:add-ci
Open

Add GitHub Actions tests#31
cclauss wants to merge 1 commit into
hishamhm:masterfrom
cclauss:add-ci

Conversation

@cclauss

@cclauss cclauss commented Jun 28, 2026

Copy link
Copy Markdown

I am learning Lua and am interested in seeing how to add GitHub Actions tests...

Test results: https://github.com/cclauss/datafile/actions

@cclauss
cclauss force-pushed the add-ci branch 4 times, most recently from 250abfa to b2a509e Compare June 28, 2026 09:25
@Tieske

Tieske commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Nice setup, looks good. But probably better to use the Lua specific actions. Some examples:

The latter is specifically useful for testing C code since it also tests multiple toolchains, which matters on Windows (but not for Lua only code like this datafile repo).

That said; both examples are outdated, since these days it's better to pin exact versions of all actions used, to prevent supply-chain/package-manager attacks.

@cclauss

cclauss commented Jul 2, 2026

Copy link
Copy Markdown
Author

I had tried the Lua-specific actions on https://github.com/bastibe/lunatic-python, but there I also needed to:
% sudo apt-get install -y liblua${{ matrix.lua-version }}-dev # so I had stopped using those actions.

I will modify this PR to try to use them here.

@cclauss
cclauss force-pushed the add-ci branch 3 times, most recently from 8abb513 to 6e6fda4 Compare July 3, 2026 15:42

@Tieske Tieske left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishamhm lgtm. Adding LuaJIT or Windows would be nice, but a great start imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants