death mode - #18
Open
jeniasaigak wants to merge 3 commits into
Open
Conversation
Owner
|
this looks awesome! I made a few minor tweaks in a branch of mine that I'll add here! One thing I'd love you opinion on: What do you think about not showing stats if the user fails in death mode? We could just throw a skull icon in the center of the terminal if they fail maybe. I kinda like the idea of making the seeing stats a rewarding experience if you're in death mode. |
Author
|
@jrnxf Your idea sounds great! I've also reviewed changes at your branch, and all of them make sense to me. I'll add it to the PR along with your proposition 👌 |
Author
|
I've just realized that it will be better to show the word and the exact place where you made a typo, along with skull at the bottom line after loosing in the death mode. Will try to implement it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Added death mode, which can be enabled via
-dflag. When the death mode is enabled, the round will be finished as soon as the user will type an incorrect symbolWhy:
If you want to become a good typist, you need to learn to type with no mistakes. This mode will enforce you to think twice on each key press and strongly decrease amount of typing mistakes. This will lead to better typing speed
How:
There is a
has_finishedfunction at game related file, which validates if the round is completed. At this PR I've additionally added a check to the function to validate it there are any mistakes in the input fieldChecklist:
Allow edits from maintainersoption checked[your_username]/(ex.thatvegandev/featureX)