Fine-Grained Admin Permissions Bypass via Role Groups…#50781
Merged
ahus1 merged 1 commit intoJul 16, 2026
Conversation
vramik
force-pushed
the
50616-fgap-partial-eval-for-client-role-groups
branch
from
July 10, 2026 10:39
21ea3a0 to
9cbbb62
Compare
vramik
marked this pull request as ready for review
July 10, 2026 11:52
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FGAP v2 group-information exposure through role group-membership endpoints.
Changes:
- Filters role-associated groups using group authorization rules.
- Requires group-list permission for the endpoint.
- Adds regression coverage for hidden groups.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ClientResourceTypeEvaluationTest.java |
Tests permission-based filtering. |
RoleContainerResource.java |
Requires group-list access. |
JpaRealmProvider.java |
Applies authorization filters to role-group queries. |
GroupRoleMappingEntity.java |
Removes the replaced named query. |
sguilhen
approved these changes
Jul 14, 2026
Closes keycloak#50616 Signed-off-by: vramik <vramik@redhat.com>
vramik
force-pushed
the
50616-fgap-partial-eval-for-client-role-groups
branch
from
July 16, 2026 12:26
9cbbb62 to
4414ad2
Compare
ahus1
previously approved these changes
Jul 16, 2026
sguilhen
approved these changes
Jul 16, 2026
ahus1
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Endpoint
Closes #50616