Manage null in BasicAuthHelper to avoid NPE#50925
Merged
Merged
Conversation
Closes keycloak#50791 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents null credentials from causing an NPE or producing the literal "null" in Basic authentication headers.
Changes:
- Converts null usernames and passwords to empty strings.
- Adds coverage for standard and RFC 6749 header handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/src/main/java/org/keycloak/util/BasicAuthHelper.java |
Safely handles null credentials. |
core/src/test/java/org/keycloak/util/BasicAuthHelperTest.java |
Tests null username and password behavior. |
gaoyikeshuer
approved these changes
Jul 15, 2026
gaoyikeshuer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rmartinc , I have reviewed it. It looks good to me
mabartos
approved these changes
Jul 16, 2026
ahus1
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50791
Little PR to send empty username/password in the authentication header if the parameter is null. Currently it throws a NPE in the RFC6749 version and string
nullin teh common method.