Skip to content

Flaky Admin UI E2E test: initial-access.spec.ts#50947

Merged
edewit merged 3 commits into
keycloak:mainfrom
mabartos:KC-50944
Jul 17, 2026
Merged

Flaky Admin UI E2E test: initial-access.spec.ts#50947
edewit merged 3 commits into
keycloak:mainfrom
mabartos:KC-50944

Conversation

@mabartos

@mabartos mabartos commented Jul 16, 2026

Copy link
Copy Markdown
Member

Closes keycloak#50944

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos marked this pull request as ready for review July 16, 2026 16:41
@mabartos
mabartos requested review from a team as code owners July 16, 2026 16:41
Copilot AI review requested due to automatic review settings July 16, 2026 16:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses flakiness in the Admin UI Playwright E2E test for client initial access tokens by adding an explicit wait after clearing filters, aiming to prevent reading table data while the UI is still transitioning from an empty/search state.

Changes:

  • Add a post-clearAllFilters() assertion intended to wait for the table to be populated before calling getTableData().

Comment thread js/apps/admin-ui/test/clients/initial-access.spec.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Copilot AI review requested due to automatic review settings July 17, 2026 09:09
@mabartos
mabartos requested a review from edewit July 17, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@edewit
edewit enabled auto-merge (squash) July 17, 2026 10:24
@mabartos mabartos self-assigned this Jul 17, 2026
Copilot AI review requested due to automatic review settings July 17, 2026 12:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@edewit
edewit merged commit 471f276 into keycloak:main Jul 17, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Admin UI E2E test: initial-access.spec.ts

3 participants