[OID4VCI] Fix credential request decryption alg downgrade vulnerability#50960
Open
dominikschlosser wants to merge 1 commit into
Open
[OID4VCI] Fix credential request decryption alg downgrade vulnerability#50960dominikschlosser wants to merge 1 commit into
dominikschlosser wants to merge 1 commit into
Conversation
Signed-off-by: Dominik Schlosser <dominik.schlosser@gmail.com>
dominikschlosser
force-pushed
the
ghi50934
branch
from
July 16, 2026 15:35
9d5c4ab to
5fa5d54
Compare
Member
|
@dominikschlosser - can you please ask someone from the working group with OID4VCI knowledge to review this one? Once it is reviewed, it is ready to be merged. |
Contributor
There was a problem hiding this comment.
Pull request overview
Binds OID4VCI credential-request decryption to the realm key’s configured algorithm, preventing JWE algorithm downgrades.
Changes:
- Rejects mismatched JWE key-management algorithms.
- Adds downgrade-test support and regression coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
services/.../OID4VCIssuerEndpoint.java |
Validates JWE alg against the selected key. |
tests/base/.../OID4VCIssuerEndpointEncryptionTest.java |
Tests rejection of RSA1_5 downgrade attempts. |
tests/utils-shared/.../Oid4vcCredentialRequest.java |
Supports overriding the JWE algorithm in tests. |
Contributor
|
@Ogenbertrand @IngridPuppet @wistefan @tdiesler @pskopek @jimmychakkalakal @graziang @thomasdarimont Could you please help review this PR when you have a chance? |
Contributor
|
LGTM |
10 tasks
IngridPuppet
approved these changes
Jul 20, 2026
IngridPuppet
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50934