add pre-triage linked issue check and labeling#50075
Closed
shawkins wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
stianst
reviewed
Jun 19, 2026
stianst
left a comment
Contributor
There was a problem hiding this comment.
I know this is a bit extra effort, but I'd prefer not to use "random" github actions, and stick mostly to actions from trusted sources like github.
Shouldn't be that hard to do a bash script that checks the commit message and PR message both contain a link to an issue (and the same issue). We should also check that the issue is open, and not closed.
I also think we perhaps should be a bit more strict in terms of how issues are linked.
- Should be on a separate line
Closes #123and notCloses: #123Closes #123and notcloses #123- Closes should be used for single issue in the same repo
- Fixes - should not be used as the GH docs states this is for issues in a different repo; we don't do that
- Resolves #123, resolves #321 - GH docs states to use this when there are multiple issues, not sure how relevant this is. Do we often do this?
Main argument for more strictness here is consistency and more importantly simplifying creating other tools/automation around issue linking.
Contributor
Author
|
@stianst no problem, I'll see what rolling our own solution looks like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of a pre-triage check as a workflow - but there wasn't yet a complete discussion of the expectations for this, so this is more for additional discussion / refinement than a fully working concept.
nearform-actions/github-action-check-linked-issues automates the linked issue check. It seemed to be the best out of several options for this task, but does not appear to be undergoing additional refinements. It only understands linked issues referenced in the PR description. See https://github.com/nearform-actions/github-action-check-linked-issues for all options - which include checking for a no-issue label to skip the check. The end result with no linked issue is a comment and a failing check.
lewagon/wait-on-check-action give us the ability to use the outcome of the dco check in a workflow. Here I'm prototyping adding or removing a lable based upon the outcome of the DC and linked issue check - but if that is not needed it can certianly be removed.