Skip to content

[CVE-2026-16072] Organization managers can create managed members thr… - #51058

Open
martin-kanis wants to merge 1 commit into
keycloak:mainfrom
martin-kanis:issue-50998
Open

[CVE-2026-16072] Organization managers can create managed members thr…#51058
martin-kanis wants to merge 1 commit into
keycloak:mainfrom
martin-kanis:issue-50998

Conversation

@martin-kanis

Copy link
Copy Markdown
Contributor

…ough stored registration links without manage-users

Closes #50998

Copilot AI review requested due to automatic review settings July 21, 2026 09:30
@martin-kanis
martin-kanis requested review from a team as code owners July 21, 2026 09:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prevents organization managers from retrieving invitation registration tokens through Admin REST APIs, addressing CVE-2026-16072.

Changes:

  • Omits invitation links from list and detail API responses with regression coverage.
  • Removes the admin-console copy-link action and translations.
  • Deprecates Java accessors and documents the compatibility change.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
testsuite/.../OrganizationInvitationManagementTest.java Tests link omission from API responses.
services/.../OrganizationInvitationResource.java Stops mapping invitation links into responses.
js/libs/.../organizationInvitationRepresentation.ts Removes the TypeScript link property.
js/apps/admin-ui/src/organizations/Invitations.tsx Removes the copy-link action.
js/apps/admin-ui/.../messages_en.properties Removes English copy-link messages.
js/apps/admin-ui/.../messages_zh_Hant.properties Removes Traditional Chinese messages.
js/apps/admin-ui/.../messages_zh_Hans.properties Removes Simplified Chinese messages.
js/apps/admin-ui/.../messages_vi.properties Removes Vietnamese messages.
js/apps/admin-ui/.../messages_uk.properties Removes Ukrainian messages.
js/apps/admin-ui/.../messages_tr.properties Removes Turkish messages.
js/apps/admin-ui/.../messages_sv.properties Removes Swedish messages.
js/apps/admin-ui/.../messages_ru.properties Removes Russian messages.
js/apps/admin-ui/.../messages_id.properties Removes Indonesian messages.
js/apps/admin-ui/.../messages_fr.properties Removes French messages.
js/apps/admin-ui/.../messages_es.properties Removes Spanish messages.
js/apps/admin-ui/.../messages_cs.properties Removes Czech messages.
js/apps/admin-ui/.../messages_ca.properties Removes Catalan messages.
docs/.../changes-26_8_0.adoc Documents the API and UI change.
core/.../OrganizationInvitationRepresentation.java Deprecates invitation-link members.

Copilot AI review requested due to automatic review settings July 21, 2026 10:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserFlowTest#testUserWithOneAdditionalFactorOtpSuccess

Keycloak CI - Base IT (5)

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

…ough stored registration links without manage-users

Closes keycloak#50998

Signed-off-by: Martin Kanis <mkanis@ibm.com>
Copilot AI review requested due to automatic review settings July 21, 2026 12:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@sguilhen sguilhen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me, but might be worth having @edewit or @ssilvert check the UI changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CVE-2026-16072] Organization managers can create managed members through stored registration links without manage-users

3 participants