Added a guide to deploy on bare-metal/VMs#51085
Conversation
Closes keycloak#50840 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
There was a problem hiding this comment.
Pull request overview
Adds a bare-metal/VM deployment blueprint for stateless multi-cluster HA and links it into the existing documentation flow.
Changes:
- Adds deployment prerequisites, topology, configuration, and verification steps.
- Links and pins the new blueprint.
- Note: the referenced issue concerns LDAP metrics and does not match this PR.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pinned-guides |
Registers the new guide. |
introduction.adoc |
Links the bare-metal blueprint. |
deploy-keycloak-bare-metal.adoc |
Adds the deployment guide. |
concepts.adoc |
Adds the guide as a next step. |
Closes keycloak#50921 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
docs/guides/high-availability/multi-cluster-v2/deploy-keycloak-bare-metal.adoc:122
- This enables trust in unsigned PROXY headers without requiring the application port to be restricted to trusted load balancers. As
server/reverseproxy.adoc:87-89notes, direct access otherwise lets clients spoof source IPs; add the network restriction to this deployment procedure.
The load balancer must also be configured to send PROXY protocol headers (for example, `send-proxy-v2` in HAProxy).
Closes keycloak#50921 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/guides/high-availability/multi-cluster-v2/deploy-keycloak-bare-metal.adoc:71
- Typing the password in an
exportcommand normally records the literal secret in shell history, contradicting the stated protection. Read it interactively without echo (or use a protected service-manager environment/credential file) before exporting it.
export KC_DB_USERNAME=<DB_USERNAME>
export KC_DB_PASSWORD=<DB_PASSWORD>
Closes keycloak#50921 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#50921 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
|
Hello @ryanemerson, Thanks for the review !!All previous comments are now resolved. Could you please re-review the PR if any other changes are needed? |
ahus1
left a comment
There was a problem hiding this comment.
Thank you for the PR, it looks good.
See below for some review comments that should be addressed before merging this one.
Closes keycloak#50921 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
This PR adds a guide to show to deploy on bare-meteal/VMs
Closes #50921