Configure OTP policy as default but with code reusable to true in BrowserFlowTest#51130
Merged
Conversation
…wserFlowTest Closes keycloak#51064 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Configures BrowserFlowTest to permit OTP reuse, preventing order- and timing-dependent failures within the same TOTP window.
Changes:
- Applies the default TOTP policy with reusable codes enabled.
- Preserves inherited test-realm password configuration.
mabartos
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51064
The issue in the test is just that the OTP policy by default does not allow to re-use the same token in the same window (30s). There are two tests using the same user to login with OTP. Depending the order and how fast the two tests are executed they can be in the same 30s window and the login fails in the second test. Just adding the configuration to re-use OTP tokens.