Incorrect authorization in admin role-composite deletion - delegated …#51136
Open
vramik wants to merge 1 commit into
Open
Incorrect authorization in admin role-composite deletion - delegated …#51136vramik wants to merge 1 commit into
vramik wants to merge 1 commit into
Conversation
…admin removes privileged child roles it cannot map Closes todo Signed-off-by: vramik <vramik@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds composite-role deletion authorization checks so delegated admins cannot remove child roles they lack permission to map.
Changes:
- Requires
MAP_ROLE_COMPOSITEpermission for every removed child role. - Applies enforcement across role-by-name and role-by-ID endpoints.
- Adds regression coverage for realm and client roles.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
RoleResourceTypeEvaluationTest.java |
Tests permitted and forbidden composite deletions. |
RoleResource.java |
Enforces child-role mapping authorization. |
RoleContainerResource.java |
Passes authorization evaluator to deletion logic. |
RoleByIdResource.java |
Enforces authorization for ID-based deletion. |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.MultipleTabsLoginTest#testLoginPageRefreshKeycloak CI - Forms IT (chrome) org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredAndRegisterClickKeycloak CI - Forms IT (chrome) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…admin removes privileged child roles it cannot map
Closes todo