Skip to content

[26.4] Mask vault password in show-config (#51013)#51151

Open
shawkins wants to merge 1 commit into
keycloak:release/26.4from
shawkins:backport-51013-26.4
Open

[26.4] Mask vault password in show-config (#51013)#51151
shawkins wants to merge 1 commit into
keycloak:release/26.4from
shawkins:backport-51013-26.4

Conversation

@shawkins

@shawkins shawkins commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
  • Mask vault password in show-config

Mark the vault password mapper as sensitive and ignore duplicate SmallRye environment aliases so the password is never shown in show-config output.

Closes #50844

Signed-off-by: Akash Kumar meakash7902@gmail.com

  • removing the second class config logic / test

Signed-off-by: Steve Hawkins shawkins@redhat.com

Signed-off-by: Akash Kumar meakash7902@gmail.com
Signed-off-by: Steve Hawkins shawkins@redhat.com
Co-authored-by: Steve Hawkins shawkins@redhat.com
(cherry picked from commit 39c424e)

@AkashKumar7902 @shawkins
Mask vault password in show-config (keycloak#51013)
afb0192 
* Mask vault password in show-config

Mark the vault password mapper as sensitive and ignore duplicate SmallRye environment aliases so the password is never shown in show-config output.

Closes keycloak#50844

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

* removing the second class config logic / test

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 39c424e)
@shawkins
shawkins requested review from a team as code owners July 24, 2026 16:15
@vmuzikar
vmuzikar enabled auto-merge (squash) July 24, 2026 16:21
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jul 24, 2026
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test13_registrationWithDefaultGroupsAndDeferredLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test13_registrationWithDefaultGroupsAndDeferredLdapCreation(LDAPGroupMapperTest.java:1080)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test14_registrationWithDefaultGroupsAndImmediateLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test14_registrationWithDefaultGroupsAndImmediateLdapCreation(LDAPGroupMapperTest.java:1089)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.noimport.LDAPGroupMapperNoImportTest#test13_registrationWithDefaultGroupsAndDeferredLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test13_registrationWithDefaultGroupsAndDeferredLdapCreation(LDAPGroupMapperTest.java:1080)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.noimport.LDAPGroupMapperNoImportTest#test14_registrationWithDefaultGroupsAndImmediateLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test14_registrationWithDefaultGroupsAndImmediateLdapCreation(LDAPGroupMapperTest.java:1089)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawkins @vmuzikar @AkashKumar7902