Admin UI cleanup: nav default-open, uploader label, Home Page nav link - #28
Merged
Conversation
…age link - AdminNavApp: sidebar nav now opens by default on desktop (was hardcoded collapsed, requiring an extra click every admin page load); mobile still starts collapsed as a drawer - AdminNavApp: add a "Home Page" sidebar link for the PR #25 home_page singleton, which previously had no entry point in the admin UI. Looks up the existing home_page item via /admin/ajax/items on mount and links straight to its editor, or to the create flow (?type=home_page) if none exists yet - AdminImageUploaderApp: drop the long comma-separated list of accepted file extensions from the upload box (was overflowing the box); the box now just prompts to click/drag, with "Or choose from uploaded" below
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up UI fixes that landed on
fix/recordpages-missing-helpersafter #27 had already been merged, so they never made it intomain. Re-landing here.AdminNavApp: sidebar nav now opens by default on desktop (was hardcoded collapsed, forcing an extra click on every admin page load). Mobile still starts collapsed as a drawer.AdminNavApp: added a "Home Page" sidebar link for the Add singleton home page content handling #25home_pagesingleton, which had no entry point anywhere in the admin UI. Looks up the existing item via/admin/ajax/itemson mount and links straight to its editor, or to the create flow (?type=home_page) if none exists yet.AdminImageUploaderApp: dropped the long comma-separated accepted-extensions list from the upload box (was overflowing it). Box now just prompts to click/drag; "Or choose from uploaded" stays below.Test plan
yarn test— 69/69 suites, 412/412 tests pass locally