Isolated Processes 1: Refactor thread_info for ease of redirecting#174
Merged
marti4d merged 2 commits intoMay 13, 2026
Merged
Conversation
marti4d
force-pushed
the
isolated_process/01-refactor-thread-info
branch
from
May 6, 2026 20:24
2f00be2 to
c0cd63a
Compare
marti4d
commented
May 6, 2026
marti4d
commented
May 6, 2026
Jake-Shadle
removed their request for review
May 7, 2026 10:53
gabrielesvelto
requested changes
May 8, 2026
gabrielesvelto
left a comment
Contributor
There was a problem hiding this comment.
Small changes here and there, most of this LGTM
Currently, thread_info is a bit of a mess and is difficult to cleanly redirect into an interface. This cleans it up and makes it easier to move around. It also fixes a piece of unsound code (mod.rs line 165) where we are passing an immutable pointer to an API that says it will modify the result.
marti4d
force-pushed
the
isolated_process/01-refactor-thread-info
branch
from
May 8, 2026 15:35
c0cd63a to
d19f007
Compare
gabrielesvelto
approved these changes
May 13, 2026
gabrielesvelto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, if @Jake-Shadle is OK with it too I'd merge it.
Collaborator
Author
|
Thanks @gabrielesvelto! @Jake-Shadle was originally a reviewer here and removed himself, so I'm going to assume that was him deferring to your judgement for the review -- So I'll merge this in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, thread_info is a bit of a mess and is difficult to cleanly redirect into an interface.
This cleans it up and makes it easier to move around.
It also fixes a piece of unsound code (mod.rs line 165) where we are passing an immutable pointer to an API that says it will modify the result.