Skip to content

Isolated Processes 2: Redirect thread_info I/O and ptrace#175

Merged
marti4d merged 2 commits into
rust-minidump:mainfrom
marti4d:isolated_process/02-redirect-thread-info
May 14, 2026
Merged

Isolated Processes 2: Redirect thread_info I/O and ptrace#175
marti4d merged 2 commits into
rust-minidump:mainfrom
marti4d:isolated_process/02-redirect-thread-info

Conversation

@marti4d

@marti4d marti4d commented May 7, 2026

Copy link
Copy Markdown
Collaborator

thread_info is complex enough to redirect that it could use its own PR for review.

@gabrielesvelto gabrielesvelto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some tiny changes.

Comment thread src/linux/minidump_writer/mod.rs Outdated
Comment thread src/linux/thread_info/x86.rs Outdated
Comment thread src/linux/process_inspection/mod.rs
Comment thread src/linux/process_inspection/mod.rs
@marti4d
marti4d force-pushed the isolated_process/01-refactor-thread-info branch from c0cd63a to d19f007 Compare May 8, 2026 15:32
@marti4d
marti4d force-pushed the isolated_process/02-redirect-thread-info branch from 329f435 to 2cf8d11 Compare May 8, 2026 15:51
@marti4d
marti4d requested a review from gabrielesvelto May 11, 2026 21:56
@marti4d
marti4d changed the base branch from isolated_process/01-refactor-thread-info to main May 13, 2026 17:14
thread_info is complex enough to redirect that it could use its own
PR for review.
@marti4d
marti4d force-pushed the isolated_process/02-redirect-thread-info branch 2 times, most recently from 14c9cc1 to 4e4f4da Compare May 13, 2026 19:36
@marti4d
marti4d force-pushed the isolated_process/02-redirect-thread-info branch from 4e4f4da to 59cfd61 Compare May 13, 2026 19:44
@marti4d

marti4d commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

@Jake-Shadle I don't want to keep assuming -- Do you want to also review these isolated process changes, or are you fine with just @gabrielesvelto doing them?

@Jake-Shadle

Copy link
Copy Markdown
Collaborator

Oh sorry, I'm completely out of the loop on these, so don't wait on my review.

@Jake-Shadle
Jake-Shadle removed their request for review May 14, 2026 16:15
@marti4d
marti4d merged commit 497a6eb into rust-minidump:main May 14, 2026
16 checks passed
@marti4d
marti4d deleted the isolated_process/02-redirect-thread-info branch May 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants