Skip to content

refactor(analysis): rename GVN state constructor#129

Merged
siyul-park merged 1 commit into
issue-124-gvn-decl-orderfrom
issue-124-gvn-naming
Jul 6, 2026
Merged

refactor(analysis): rename GVN state constructor#129
siyul-park merged 1 commit into
issue-124-gvn-decl-orderfrom
issue-124-gvn-naming

Conversation

@siyul-park

Copy link
Copy Markdown
Owner

Summary

  • rename the private newGNumbering helper to newNumbering
  • keep the name focused on the helper's role within analysis/gvn.go instead of repeating the GVN/file context
  • leave behavior unchanged

Stacked on #127 so the diff stays limited to the naming convention follow-up.

Testing

Not run locally; repository checkout/test execution was not available in this environment. Verified with compare that this branch only changes two call/definition lines in analysis/gvn.go.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 289b4a78-7717-4222-bea3-071adce71846

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-124-gvn-naming

Comment @coderabbitai help to get the list of available commands.

@siyul-park
siyul-park merged commit adfbc1f into issue-124-gvn-decl-order Jul 6, 2026
3 checks passed
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.80%. Comparing base (9aacd8a) to head (a14161c).
⚠️ Report is 1 commits behind head on issue-124-gvn-decl-order.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           issue-124-gvn-decl-order     #129      +/-   ##
============================================================
+ Coverage                     46.79%   46.80%   +0.01%     
============================================================
  Files                            77       77              
  Lines                         17340    17340              
============================================================
+ Hits                           8114     8116       +2     
+ Misses                         8307     8306       -1     
+ Partials                        919      918       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant