Cover cases in polygonToCells which fail after estimation#1196
Merged
Conversation
|
coverage: 99.662% (+0.2%) from 99.475% — isaacbrodsky:polygon-to-cells-nan into uber:master |
dfellis
approved these changes
Jul 24, 2026
Comment on lines
+516
to
+529
| TEST(polygonToCells) { | ||
| int64_t numHexagons; | ||
| t_assertSuccess(H3_EXPORT(maxPolygonToCellsSize)(&invalidSfGeoPolygon, | ||
| 9, 0, &numHexagons)); | ||
| H3Index *hexagons = calloc(numHexagons, sizeof(H3Index)); | ||
|
|
||
| t_assert(H3_EXPORT(polygonToCells)(&invalidSfGeoPolygon, 9, 0, | ||
| hexagons) == E_FAILED, | ||
| "Partially NAN geo polygon cannot be evaluated"); | ||
|
|
||
| free(hexagons); | ||
| } | ||
|
|
||
| TEST(polygonToCellsHole) { |
Collaborator
There was a problem hiding this comment.
Just a nit on the test names; they're not super descriptive on what is being tested.
Collaborator
Author
There was a problem hiding this comment.
Oops, that's a mistake. Fixed.
justinhwang
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.