Conversation
bjwtaylor
force-pushed
the
tl13-transform-resource-leak
branch
from
August 25, 2026 12:36
27c787f to
2a37227
Compare
bjwtaylor
marked this pull request as ready for review
August 26, 2026 07:18
gilles-peskine-arm
self-requested a review
August 26, 2026 07:37
gilles-peskine-arm
requested changes
Aug 26, 2026
gilles-peskine-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM except the test assertion isn't precise enough
gilles-peskine-arm
approved these changes
Aug 27, 2026
| #endif | ||
|
|
||
| PSA_INIT(); | ||
| TEST_CALLOC(keys, SSL_TEST_MAX_VOLATILE_KEYS + 1); |
Contributor
There was a problem hiding this comment.
I wonder why you went back to a dynamic allocation, even though the size is known at compile time?
Contributor
Author
There was a problem hiding this comment.
For some reason one of the compilers was complaining about it in one of the tests and this seemed to resolve the issue. I would link the test, though I don't think the CI has kept it.
Contributor
Author
|
@gilles-peskine-arm are you happy for me to squash this into the original 3 commits to assist the backports? |
Contributor
|
Ok to rewrite the history to (test, fix, changelog). |
added 3 commits
September 23, 2026 08:30
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
bjwtaylor
force-pushed
the
tl13-transform-resource-leak
branch
from
September 23, 2026 07:38
aeaab79 to
5b4be7e
Compare
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix resource leak in populate transform fixes #10917
PR checklist