FileInput: apply utility classes to the wrapper element#6646
Open
IRennie74 wants to merge 1 commit into
Open
Conversation
Utility properties such as Display and Margin were applied to the inner file <input> instead of the wrapper element, so e.g. Display.None did not hide the control. FileInput now defaults UtilityTarget to Wrapper (via a new DefaultUtilityTarget override) for the providers that render a wrapper (AntDesign, Bootstrap, Bootstrap5, Bulma, FluentUI2), and each wrapper now renders the wrapper utility classes and styles. AntDesign also gains an ant-upload-wrapper root element so Display.None hides the whole control, not just the upload button. The core bare-input providers (Material, Tailwind) keep targeting the input itself. Closes Megabit#6522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FileInput applied utility properties like
DisplayandMarginto the inner<input>instead of the wrapper, so e.g.Display.Nonedid not hide the control.Utilities now target the wrapper.
Closes #6522
Types of changes