Skip to content
This repository was archived by the owner on Nov 28, 2023. It is now read-only.
This repository was archived by the owner on Nov 28, 2023. It is now read-only.

why not update code before finish action? #98

Description

@teddy-hoo

I begin a release usinggit hf release start 2.4
and someone else in my team merged his change to release/2.4 using github pull request.
I finish this release on local without executing a git hf update

Finally, my teammates' change is lost!

It is harmful!

Activity

  1. stuartherbert commented on Apr 16, 2018

    @stuartherbert

    I'm not sure how that could have happened.

    According to the code Hubflow does a pull from origin at the start of a git hf release finish command. It then immediately pushes local back up to origin.

    If anyone has a way to reproduce this problem, I'll happily dig into it further.

  2. teddy-hoo commented on Apr 17, 2018

    @teddy-hoo
    Author

    Hi, I can reproduce it stably.

    # instance 1
    git hf hotfix start 2.9.11
    
    #instance 2
    git pull
    git checkout hotfix/2.9.11
    # make some change
    git commit -m 'test gitflow'
    git push
    
    #instance 1
    git hf hotfix finish 2.9.11
    

    with above operations, i can not get commit 'test gitflow' on instance 1.

    and i see code here, it just fetch but no merge, and then merge using local branch code here .

  3. etienne-napoleone commented on Jul 6, 2018

    @etienne-napoleone

    @teddy-hoo Why are you using :

    • git pull instead of git hf pull
    • git checkout instead of git hf checkout
    • git push instead of git hf push

    Is it a typo in your post? If not, there's your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    more information requiredWaiting for the original poster to come back with further information.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions