Repository navigation
Dnssec nsec validation - #162
Merged
Merged
Conversation
Coverage Report for CI Build 39406732699Coverage increased (+0.1%) to 63.986%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions48 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
verifyNsec() only rejected a negative response if it contained an NSEC
or NSEC3 record that did not prove the denial of existence ("Invalid
NSEC!"). If the response contained no NSEC(3) record at all, the
denial was accepted as authentic as long as, e.g., a validly signed
SOA RR was present. An attacker able to inject responses could thus
forge an authentic denial of existence for any name or type in a
signed zone by replaying the zone's signed SOA RR and omitting the
NSEC(3) records.
A negative response is now only authentic if a valid NSEC(3) proof is
present; otherwise the new NoDenialOfExistenceReason is reported. This
resolves the "Shouldn't we also throw if !nsecPresent?" TODO.
Verifier.verifyNsec3() hashed the queried name as many times as the NSEC3 RR requested, without an upper bound. An attacker-supplied NSEC3 RR with a large iteration count could thus impose expensive hashing. NSEC3 RRs with more than 100 iterations are now rejected before hashing, as recommended by RFC 9276 § 3.2, with the new Nsec3IterationCountExceededReason.
Flowdalic
force-pushed
the
dnssec-nsec-validation
branch
from
October 20, 2026 10:16
7219fbf to
ac9aa39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.