Repository navigation
examples: fix duplicate event_sequence in Run as Directed work example - #147
Merged
carlfredl merged 1 commit intoJun 29, 2026
Merged
Conversation
The run_events.txt block for run (weekday, 10000) uses event_sequence 30 on both the run-as-directed row and the following deadhead row, which violates the declared Primary Key (service_id, run_id, event_sequence) and the rule that event_sequence 'Must be unique within one (service_id, run_id).' Bump the trailing deadhead event to 40 (any non-duplicate value works, since sequences need not be consecutive).
|
|
skyqrose
approved these changes
Jun 24, 2026
skyqrose
left a comment
Contributor
There was a problem hiding this comment.
I wrote this example back in https://github.com/MobilityData/transit-operational-data-standard/pull/66/changes#diff-788373b6538c505c2ade4325b74c888767505552caefabf6b99c5249de77d556R169
This is totally just a typo. Thanks for the catch.
jeffkessler-keolis
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
run_events.txtblock in the Run as Directed work example usesevent_sequence30 on two rows of run(weekday, 10000):run_events.txtdeclares Primary Key(service_id, run_id, event_sequence)and statesevent_sequence"Must be unique within one (service_id,run_id)", so the example contradicts its own rule. The two events are sequential (09:00 to 12:00, then 12:00 to 12:10), so this bumps the trailing deadhead to40(any non-duplicate value works, since sequences need not be consecutive).Per the design discussion in #60,
event_sequencevalues "must be different" even when two events share a start/end time, so this looks like a slip in the example rather than an intended tie. I found this while building a TODS validator, and I'm happy to adjust if40isn't the preferred convention.