Skip to content

caniuse error solution - #2732

Open
techwithsrikanth wants to merge 1 commit into
Modernizr:masterfrom
techwithsrikanth:caniuserrorupdate
Open

techwithsrikanth wants to merge 1 commit into
Modernizr:masterfrom
techwithsrikanth:caniuserrorupdate

Conversation

@techwithsrikanth

Copy link
Copy Markdown

To resolve this issue, the code has been updated to provide custom handling for the "forms" feature, as this feature was not supported by the existing mapping.

_.forEach(Modernizr, function(result, feature) {

if (_.includes(_.keys(map), 'forms')) {
describe('Custom handling for "forms" feature', function() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this function for and where di you copy if from?

var majorminor = ua.browser.version.replace(/(9\.(6|5))/, ua.browser.name === 'Opera' ? '9.5-9.6' : '$1')
.replace(/(10\.(0|1))/, ua.browser.name === 'Opera' ? '10.0-10.1' : '$1');

// make sure the version keys of the caniusedata is sorted as numbers not as strings

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the comments?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants