Fix penalties and add tests - #1668
Merged
Merged
Conversation
RoyStegeman
reviewed
Jan 26, 2023
RoyStegeman
left a comment
Member
There was a problem hiding this comment.
I don't think anyone is using this, though @Zaharid did contact me about it recently so he may want to be aware of this.
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
RoyStegeman
reviewed
Jan 29, 2023
scarlehoff
commented
Jan 30, 2023
scarlehoff
commented
Jan 30, 2023
RoyStegeman
approved these changes
Jan 30, 2023
Member
|
I think this is ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have been broken since a while, but since nobody used them it didn't really matter.
Don't think they will be used but who knows, I added a few tests since (even if they are not used in practice) they ensure that several pieces of the code work well together as they require the correct flavours being set,
n3fitmodel to be compatible with validphys, etc.