don't compute predictions for all replicas if we only want replica0 - #2004
Merged
Conversation
RoyStegeman
force-pushed
the
rs-quickfix
branch
2 times, most recently
from
March 14, 2024 10:46
5c76ad1 to
99dc6a5
Compare
scarlehoff
reviewed
Mar 14, 2024
RoyStegeman
force-pushed
the
rs-quickfix
branch
from
March 14, 2024 13:36
2548418 to
8b22f58
Compare
andreab1997
reviewed
Mar 14, 2024
andreab1997
left a comment
Contributor
There was a problem hiding this comment.
It seems fine but, remind me, what is it used in the thcovmat creation? I remember we faced this issue some months ago as well
Member
Author
|
Indeed in the function that enables me to do this is the on created to make the thcovmat computation cheaper: #1863. @andreab1997 this function derives from the same function, but specifically this is the one in the alphas TCM notebook. So it should make computing the posterior quite a bit lighter and faster. |
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
RoyStegeman
force-pushed
the
rs-quickfix
branch
from
March 14, 2024 15:11
0213e71 to
1179b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.